rusackas commented on code in PR #30196:
URL: https://github.com/apache/superset/pull/30196#discussion_r1750488083
##########
superset-frontend/lerna.json:
##########
@@ -19,4 +23,4 @@
}
},
"$schema": "node_modules/lerna/schemas/lerna-schema.json"
-}
+}
Review Comment:
Right... these are generated by lerna. They were getting caught by the
pre-commit, but then it mods the files, which means you can't do the release...
it's an annoying catch-22. I'll try to find a way around it in this or a
subsequent PR.
Actually, now that I look at CI, there's a similar thing where I need to
prepend the ASF license to CHANGELOG.md files... so I'll have to add a script
for that at the very least to get the PR through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
