giftig commented on PR #30132: URL: https://github.com/apache/superset/pull/30132#issuecomment-2339091916
My comments aren't really blocking, just a small improvement which would be nice imo. It's an easy +1 for me if the tests can be separated like they were before but without the repetition of test fixtures, but it's not a big enough issue to block the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
