geido commented on PR #30215: URL: https://github.com/apache/superset/pull/30215#issuecomment-2346587991
> @geido If possible, could you use a more descriptive name for the commands? Maybe `MakeFavoriteCommand` and `RemoveFavoriteCommand`? If the goal is to help people with finding all code related to favorites I believe `AddFavoriteDashboardCommand` and `RmFavoriteDashboardCommand` should be enough. Trying not to create a string that is just too long. These seem already on the edge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
