xiaoshan1213 opened a new issue, #30256: URL: https://github.com/apache/superset/issues/30256
*Please make sure you are familiar with the SIP process documented* [here](https://github.com/apache/superset/issues/5602). The SIP will be numbered by a committer upon acceptance. ## [SIP] Proposal for Save SQL lab query result and create sharable link ### Motivation Currently, Superset has the function to save the query and create a sharable link, but the query results is not associated with the sharable link, whoever open the sharable link need to rerun the query to get results. It is a waste of compute power and time for our customers. We are proposing to save query result along when user save the query, and associate the result along with the sharable link so whoever open the link can see the result. ### Proposed Change 1. Modify the /api/v1/saved_query/ POST function to include the results id within the request parameter. 2. Modify the /api/v1/saved_query/{savedQueryId} GET function to return the results id within the response parameter. 3. Modify the saved query metadata db to include the results id field. ### New or Changed Public Interfaces 1. Modify the /api/v1/saved_query/ POST function to include the results id within the request parameter. 2. Modify the /api/v1/saved_query/{savedQueryId} GET function to return the results id within the response parameter. ### New dependencies No ### Migration Plan and Compatibility the metadata db will add a new field results_id, we need to migrate existing db records to include a empty string for this field. ### Rejected Alternatives Another approach not rejected but list here, we can create a new API to save query results and new API to create sharable link to share results so as to not modify the existing APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
