betodealmeida commented on code in PR #30258: URL: https://github.com/apache/superset/pull/30258#discussion_r1757558164
########## superset/db_engine_specs/base.py: ########## @@ -63,7 +63,8 @@ from superset.databases.utils import get_table_metadata, make_url_safe from superset.errors import ErrorLevel, SupersetError, SupersetErrorType from superset.exceptions import DisallowedSQLFunction, OAuth2Error, OAuth2RedirectError -from superset.sql_parse import ParsedQuery, SQLScript, Table +from superset.sql.parse import SQLScript, Table +from superset.sql_parse import ParsedQuery Review Comment: Oh, sorry, I forgot to mention that the goal is to get rid of `sql_parse.py`. The new `superset/sql/` directory will use only `sqlglot`, and as I'm working on SIP-117 I'm taking `sqlparse` logic from `sql_parse.py` and reimplementing it using `sqlglot` in `sql/parse/`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
