williaster commented on a change in pull request #7390: [dashboard] allow user
re-order top-level tabs
URL:
https://github.com/apache/incubator-superset/pull/7390#discussion_r279120068
##########
File path: superset/assets/src/dashboard/actions/dashboardLayout.js
##########
@@ -176,11 +196,8 @@ export function handleComponentDrop(dropResult) {
dispatch(moveComponent(dropResult));
}
- const { dashboardLayout: undoableLayout } = getState();
-
// if we moved a child from a Tab or Row parent and it was the only child,
delete the parent.
if (!isNewComponent) {
- const { present: layout } = undoableLayout;
Review comment:
I think this should be an **up-to-date** version of `state` (i.e., after the
possible `dispatch`es above). If you need it above then I would call
`getState()` again down here so it's not stale (`getState` always returns the
most up-to-date version of `state`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
