michael-s-molina commented on code in PR #30318:
URL: https://github.com/apache/superset/pull/30318#discussion_r1765455319
##########
superset-frontend/src/constants.ts:
##########
@@ -111,6 +111,14 @@ export const URL_PARAMS = {
name: 'focused_chart',
type: 'number',
},
+ language: {
Review Comment:
I believe the correct parameter here should be locale which is comprised of
both the language and region. Another point is that we should be able to infer
the currency from the locale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
