rjurney opened a new issue #7394: superset.cli.runserver: workers/timeout parameters backwards URL: https://github.com/apache/incubator-superset/issues/7394 In [`superset/cli.py](https://github.com/apache/incubator-superset/blob/release--0.31/superset/cli.py#L103-L112) I looked up click and it indicated the specified order is usually what works. Is this a bug? Hate to bug you but I've never used click before. https://github.com/apache/incubator-superset/blob/release--0.31/superset/cli.py#L103-L112 ```python @click.option('--workers', '-w', default=config.get('SUPERSET_WORKERS', 2), help='Number of gunicorn web server workers to fire up [DEPRECATED]') @click.option('--timeout', '-t', default=config.get('SUPERSET_WEBSERVER_TIMEOUT'), help='Specify the timeout (seconds) for the ' 'gunicorn web server [DEPRECATED]') @click.option('--socket', '-s', default=config.get('SUPERSET_WEBSERVER_SOCKET'), help='Path to a UNIX socket as an alternative to address:port, e.g. ' '/var/run/superset.sock. ' 'Will override the address and port values. [DEPRECATED]') def runserver(debug, console_log, use_reloader, address, port, timeout, workers, socket): ``` Note how the `@click` ordering is workers, timeout the runserver() ordering is timeout, workers. I have no idea what effect this is having. ### Expected results None noticed. ### Actual results None noticed. #### How to reproduce the bug 1. Go to cli.py 2. Read line 103-112 3. See parameter ordering error ### Environment (please complete the following information): - superset version: [e.g. `release--0.31`, `b3aa5633`] ### Checklist Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any. - [x] I have reproduced the issue with at least the latest released version of superset. - [x] I have checked the issue tracker for the same issue and I haven't found one similar. ### Additional context Add any other context about the problem here.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
