villebro commented on code in PR #30325: URL: https://github.com/apache/superset/pull/30325#discussion_r1768956755
########## tests/unit_tests/db_engine_specs/test_postgres.py: ########## @@ -20,10 +20,11 @@ import pytest from pytest_mock import MockerFixture -from sqlalchemy import types +from sqlalchemy import column, types from sqlalchemy.dialects.postgresql import DOUBLE_PRECISION, ENUM, JSON from sqlalchemy.engine.url import make_url +from superset.db_engine_specs.postgres import PostgresEngineSpec as spec Review Comment: Nice, apparently the circular import that's been there before is no longer an issue 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
