sfirke commented on issue #29251: URL: https://github.com/apache/superset/issues/29251#issuecomment-2368464167
There are many things going on in this issue, much of which have been resolved. I'm going to close it because that makes issues not useful for bug tracking. To recap + respond: - How to change the comma separator of how Superset displays float numbers: people should be able to simply set `D3_FORMAT=` in their custom `superset_config.py` as covered in this discussion and the pull request it links to: https://github.com/apache/superset/discussions/29113 You should not have to change Superset's code and rebuild an image. If this isn't working please post in that discussion comments or on Slack. - The original poster of this GitHub issue had a problem caused by a typo, pluralizing the variable name. - Changing the format of the export via CSV_EXPORT: @fabgat I agree with your approach of passing argument to pandas `DataFrame.to_csv` via the `CSV_EXPORT` config settings. Looks like `thousands` is not a supported keyword, see the docs here: https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.to_csv.html I think your best bet is to investigate the `float_format` argument, playing with it outside of Superset until you find the setting you need. If you think this needs work, is a bug, or you have a contribution to make, feel free to post a new GitHub issue and tag me. Or if you get it working, feel free to reply here with your solution or make a new GitHub Discussion and self-answer it so others can learn from it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
