rusackas commented on PR #30305: URL: https://github.com/apache/superset/pull/30305#issuecomment-2371898001
@birkskyum to test/review these PRs, we typically need to check the plugin. There are a few ways to do this: 1) starting an ephemeral env here so anyone can test it (needs to be done by a committer) 2) pulling the change locally and running Superset (better in this case so we can add a mapbox key) 3) pulling the change locally and running Storybook I'll start with #1 here before I approve. @mistercrunch was your review a code review, or did you test/validate the upgrade? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
