rusackas commented on PR #30364:
URL: https://github.com/apache/superset/pull/30364#issuecomment-2372051022
I think this PR is a fantastic step in the right direction ❤️
If there's interest/bandwidth to take things a step further, it's worth
noting that deleting a dataset might break HUNDREDS of charts. While this PR
allows you to restore them one at a time, it might be a great idea to (also)
allow this swap/substitution in the Dataset deletion modal. You could give the
user any/all of these choices:
* Replace {deleted dataset} with [Select dataset ˅]
* Delete dataset (charts will be broken)
* Delete dataset and affected charts
Of course, taking it even further over the horizon, we probably shouldn't be
deleting _anything_ but rather doing "soft deletes" where rows are tagged as
deleted, so that they can be restored by a DBA. (Note, this is not the same as
"Archiving" which requires UI changes and un-archiving capabilities.
Love the PR, but just saying this is the entry of a longer tunnel ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
