rusackas commented on PR #30354: URL: https://github.com/apache/superset/pull/30354#issuecomment-2372508030
> Matrix (1, chrome) failed so I restarted it manually. For the record `dashboard/nativeFilters.test.ts` is the one that failed, even after shrinking it down as part of this PR. I'm wondering if lowering the limit / cardinality of filters could help here too if the issue comes from too many filters with too high of a cardinality (assuming that this specific test is the hot spot). > > Wondering if a wider matrix would help. Also it seems we have 5 * chrome now, but could try running also against Firefox to see if the memory consuption is more or less of a problem on that browser. Yes, that is the hot spot, and it's always the one that fails. We've also seen GitHub issues about performance regressions when there are lots of filters, so this failure is likely reflecting a real problem. We can throw memory, split tests, reduce test scope, etc. to smooth out devEx, but I think we're just dancing around a real problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
