hainenber commented on PR #30357: URL: https://github.com/apache/superset/pull/30357#issuecomment-2374335764
> - Uplift fetch-mock to v11 + corresponding refactoring for superset-ui-core. > - Uplift following packages to latest version. > - @testing-library/react-hooks > - @testing-library/jest-dom > - webpack-cli These are dev dependencies and any breakages are detected in `frontend-build` CI. Current check is green so these uplift are safe > Move @types/* packages in superset-ui-core to devDependencies. Moving of `@types/*` package that are actual dependency will generate linting issue. This can be illustrated by moving `@types/json-bigint` into devDependencies in `superset-ui-core`. Current build is green so the uplift is safe. <img width="1050" alt="image" src="https://github.com/user-attachments/assets/919fb04c-c268-4e9f-a70a-6d45a183f08c";> Only risk is with `npm audit fix` as it might bump packages not respecting semver. However, from my inspection, they're mostly version bumps of dev dependencies (this is at 95% confidence interval :D) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
