villebro commented on code in PR #30380:
URL: https://github.com/apache/superset/pull/30380#discussion_r1775760734


##########
superset/views/core.py:
##########
@@ -792,9 +792,16 @@ def dashboard(
         try:
             dashboard.raise_for_access()
         except SupersetSecurityException as ex:
+            # anonymous users should get the login screen, others should go to 
dashboard list
+            if g.user is None or g.user.is_anonymous:
+                redirect_url = 
f"{appbuilder.get_url_for_login}?next={request.url}"

Review Comment:
   Great, nice finishing touch to this! 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to