mistercrunch commented on issue #26646: URL: https://github.com/apache/superset/issues/26646#issuecomment-2378209244
From my perspective the SIP is lacking important details. Allowing people to run whatever is a pre-query block might not be something that administrators want to allow. ```sql CREATE TABLE IF NOT EXISTS super_massive_unefficient_analyst_query_that_scans_a_petabyte_table AS SELECT * FROM massive_petabyte_table; ``` For me to vote positive, there should be a database configuration flag (off by default) that's called something like `ENABLE_PRE_QUERY_BLOCK_FOR_VIRTUAL_DATASETS: false` (could be in extra_metdata json blob). Oh that an a better separator, maybe `--__QUERY_START__` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
