mistercrunch commented on code in PR #30395:
URL: https://github.com/apache/superset/pull/30395#discussion_r1777897432


##########
.github/workflows/bashlib.sh:
##########
@@ -162,7 +162,17 @@ cypress-run-all() {
     USE_DASHBOARD_FLAG='--use-dashboard'
   fi
 
-  python ../../scripts/cypress_run.py --parallelism $PARALLELISM 
--parallelism-id $PARALLEL_ID $USE_DASHBOARD_FLAG
+  docker pull cypress/browsers:node-20.16.0-chrome-127.0.6533.119-1
+
+  docker run --rm \
+    -e CYPRESS_BASE_URL \
+    -e PARALLELISM \
+    -e PARALLELISM_ID \
+    -e USE_DASHBOARD=${USE_DASHBOARD} \
+    -v "$GITHUB_WORKSPACE/superset-frontend/cypress-base:/e2e" \
+    -w /e2e \
+    cypress/browsers:node-20.16.0-chrome-127.0.6533.119-1 \
+    npx cypress run --browser chrome $USE_DASHBOARD_FLAG

Review Comment:
   I think that mean means no parallelism, guessing you're not meaning to merge 
this change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to