villebro commented on code in PR #30412:
URL: https://github.com/apache/superset/pull/30412#discussion_r1778848214
##########
superset/config.py:
##########
@@ -1510,6 +1510,14 @@ def EMAIL_HEADER_MUTATOR( # pylint:
disable=invalid-name,unused-argument
"postgresql": "PostgreSQLValidator",
}
+# A list of database dialects which the query ID is not related to the
connection.
+# The database dialects set here will update the `cancel_query` value
+# in the `extra` field of the `query` object after executing the corresponding
SQL and
+# before retrieving the result set
+QUERY_ID_NOT_ASSOCIATED_CONNECT: list[str] = [
+ "impala",
+]
Review Comment:
Is there a reason this is put in `config.py`? The typical solution would be
to add a new class property in `BaseEngineSpec` that's disabled by default, but
is then set to true on the specific spec (in this case `ImpalaEngineSpec`). But
please correct me if I'm misunderstanding something here..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
