rusackas commented on PR #30397: URL: https://github.com/apache/superset/pull/30397#issuecomment-2380400505
There's just one thing that might be worth consideration before merging. If I'm reading this right, any test that fails (after retries) will exit the whole Cypress_run script. This differs from normal Cypress behavior, where all test are run, and multiple failures are allowed to happen. Think there's a good way to log the failure, keep running tests, and _then_ fail CI at the end like Cypress does today? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
