fmannhardt commented on code in PR #30425:
URL: https://github.com/apache/superset/pull/30425#discussion_r1792979844
##########
superset/commands/dashboard/export.py:
##########
@@ -190,6 +201,5 @@ def _export(
if dataset_id is not None:
dataset = DatasetDAO.find_by_id(dataset_id)
if dataset:
- target["datasetUuid"] = str(dataset.uuid)
Review Comment:
Done. Since this is now only to invoke the dataset export, it is fine to
have the condition before iterating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
