mklumpen opened a new pull request, #30577:
URL: https://github.com/apache/superset/pull/30577

   ### SUMMARY
   The issue is caused by a custom style in the forked version of cosmo 
bootswatch.less that was added in the original [multi-panel sqllab 
PR](https://github.com/apache/superset/pull/514/). The style overrides the 
caret style that is part of the bootstrap dropdown.less and references the 
FontAwesome font which is no longer included. The fix updates the bootswatch 
style to use Glyphicons down-chevron icon that is similar to the icons used in 
the React implementations. An alternative would be to remove the style from 
bootswatch completely, which can be seen in the ALTERNATE screenshot below.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   BEFORE:
   
![show_user_current](https://github.com/user-attachments/assets/85ed4541-fd1c-4c39-a3cb-0dff1740d959)
   
   AFTER:
   
![show_user_proposed](https://github.com/user-attachments/assets/029806ed-ebda-4929-8cc9-cfb6e5b9d9fc)
   
   ALTERNATE: would be implemented by completely removing the caret style in 
the forked bootswatch.less and allowing boostrap dropdowns.less style to be 
applied:
   
   
![show_user_alternate](https://github.com/user-attachments/assets/9ab4d7f8-5b4f-4652-8837-e47c5b04ffdc)
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   Fixes #30514
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to