betodealmeida commented on PR #30578: URL: https://github.com/apache/superset/pull/30578#issuecomment-2407919084
@michael-s-molina I agree, I think ideally we want to have a close relationship with `sqlglot` (since we need to have a robust parser in order to enforce DAR and RLS reliably), so I hope we'll able to quickly address problems like this in the future by contributing upstream — creating a Firebolt dialect instead of relying on `sqlparse`, eg. I'll add the deprecation notice. For 5.0 we can simply return the query as-is for DB engine specs without a `sqlglot` dialect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
