villebro commented on code in PR #30599:
URL: https://github.com/apache/superset/pull/30599#discussion_r1800180820
##########
superset-frontend/packages/superset-ui-core/src/number-format/factories/createDurationFormatter.ts:
##########
@@ -17,7 +17,7 @@
* under the License.
*/
-import prettyMsFormatter from 'pretty-ms';
+import prettyMilliseconds, { Options } from 'pretty-ms';
Review Comment:
Renaming the default export to `prettyMilliseconds`, as that's what it's
called in the source, and pull in `Options` via the newly exposed named export.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
