graceguo-supercat opened a new pull request #7411: [SQL Lab] Increase timeout threshold for offline check URL: https://github.com/apache/incubator-superset/pull/7411 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY In #6013, we introduced a feature: in sql lab, after user sent out query, if there is no response from backend in a few seconds, sql lab will display `offline` label, to remind user to check network connection or VPN connection. This feature was trying to fix an issue like, a user might open sql lab in an environment without internet connection, or move computer from one place to another, when he run sql lab, the query may stuck in `pending` state for a long time, but user may not be aware it's network connection issue or sql lab performance issue. The threshold for waiting backend response was 7 seconds. But we found many users in slow internet connect (or VPN) environment, 7 seconds is too short. So they will see `offline` label first, then query response come back later, this experience is very confusing. In this PR, i want to increase the wait threshold from 7 second to 10 seconds. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF no ### TEST PLAN manual test ### REVIEWERS @john-bodley @timifasubaa @michellethomas
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
