mistercrunch commented on code in PR #30588:
URL: https://github.com/apache/superset/pull/30588#discussion_r1803911095
##########
superset-frontend/packages/superset-ui-chart-controls/src/components/labelUtils.tsx:
##########
@@ -55,8 +55,7 @@ const TooltipSection = ({
text: ReactNode;
}) => (
<TooltipSectionWrapper>
- <TooltipSectionLabel>{label}</TooltipSectionLabel>
- <span>{text}</span>
+ <TooltipSectionLabel>{label}</TooltipSectionLabel>: <span>{text}</span>
Review Comment:
I had a `{' '}` and I think prettier changed it to what is now there.
Generally I prefer the `{' '}` to ` `, and if prettier is configured to do
what it did, let's roll with it. About the span, I think it's referenced in the
CSS so that it's not bolded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
