rusackas commented on code in PR #30646:
URL: https://github.com/apache/superset/pull/30646#discussion_r1806729118
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/editmode.test.ts:
##########
@@ -42,15 +42,29 @@ function openProperties() {
cy.getBySel('header-actions-menu')
.contains('Edit properties')
.click({ force: true });
- cy.wait(500);
+ cy.get('.ant-modal-body').should('be.visible');
Review Comment:
could add a `data-test` attribute to select if that's considered more stable
than the antD class name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
