giftig commented on PR #29311: URL: https://github.com/apache/superset/pull/29311#issuecomment-2429112478
@vicky-sai in its current state it has important outstanding comments as above -- it's broken the build and an important test is failing, and it needs a better explanation of what it's attempting to do (which might also clarify how it can be properly fixed). However it looks like @Hen0k has verified that this issue has already been resolved in 4.1rc2. I'd suggest seeing if that build works for you too. If it's fixed in the release candidate we can just close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
