michael-s-molina commented on code in PR #26230:
URL: https://github.com/apache/superset/pull/26230#discussion_r1818890719
##########
superset-frontend/plugins/legacy-plugin-chart-calendar/src/transformProps.js:
##########
@@ -35,12 +35,21 @@ export default function transformProps(chartProps) {
subdomainGranularity,
xAxisTimeFormat,
yAxisFormat,
+ colorRangeEnd,
+ colorRangeStart,
} = formData;
const { verboseMap } = datasource;
const timeFormatter = ts => getFormattedUTCTime(ts, xAxisTimeFormat);
const valueFormatter = getNumberFormatter(yAxisFormat);
+ // Get the color range if both are specified
+ const useCustomColorRange =
Review Comment:
Shouldn't we validate for integers instead?
```
const useCustomColorRange =
isNumber(colorRangeStart) && isNumber(colorRangeEnd);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
