geido commented on PR #30719: URL: https://github.com/apache/superset/pull/30719#issuecomment-2442069401
> * Should it indicate that the filter was applied? > * Should the query also apply the filter? @michael-s-molina the backend takes the judgement here about what should be applied and what not. I think if the filter is inapplicable it should not be applied and there should not be an indication as well. The user is informed that the chart will reload by loading when the filters get applied, that should give enough confidence to the user that there was an attempt to apply the filter but it was deemed inapplicable at query time. > The applied scopes seems to be correct when loading and highlighting charts. It looks like there's a bug when rendering the scope tab as it's not correctly identifying that not all charts are selected. I believe this issue existed in master due to excessive optimizations of the state. I'have fixed it in the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
