sfirke opened a new pull request, #30743:
URL: https://github.com/apache/superset/pull/30743

   ### SUMMARY
   `true` doesn't work for Microsoft SQL Server, Oracle, or DB2 (see 
https://en.wikipedia.org/wiki/List_of_SQL_reserved_words) and its purpose 
confused me with no explanation.  @nytai and @giftig helped me figure it out on 
Slack.
   
   ### TESTING INSTRUCTIONS
   I tried `WHERE 1 = 1` on SQL Server and Postgres to verify they both accept 
that logic ... I would think no RDBMS would fail there but who knows.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to