kristw commented on issue #7350: Refactor out controlUtils.js module + unit tests URL: https://github.com/apache/incubator-superset/pull/7350#issuecomment-487942573 This LGTM @mistercrunch I will take care of resolving conflicts in my PR after you merge. Best regards, Krist -- Krist Wongsuphasawat http://kristw.yellowpigz.com On Apr 30, 2019, 08:22 +0700, michellethomas <[email protected]>, wrote: > this lgtm thanks for doing this! I did a little testing with production data and didn't see any issues. You might want to sync up with @kristw before merging because this conflicts with #6827 > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
