fxprunayre opened a new pull request, #27476:
URL: https://github.com/apache/superset/pull/27476

   ### SUMMARY
   
   In the DeckGL map plugin we can only select a Mapbox style from the 
[predefined 
list](https://github.com/apache/superset/blob/2499a1cf5a7f298c1ee2f34b3d67ca1d18bb7457/superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/Shared_DeckGL.jsx#L373-L380)
 or [typing a new Mapbox style 
URL](https://github.com/apache/superset/pull/26031).
   
   This change add support for tile server layer making use of Deck.gl 
[TileLayer](https://deck.gl/docs/api-reference/geo-layers/tile-layer). The well 
known [OpenStreeMap](https://www.openstreetmap.org/) layer provided by 
https://[abc].tile.openstreetmap.org/{z}/{x}/{y}.png is added to the list 
making easier for users not having a Mapbox account to have a background layer 
on map charts.
   
   It has been tested with other tile server URL 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Choose Mapbox, Openstreetmap or use a custom mapbox or tile URL
   
   
![image](https://github.com/apache/superset/assets/1701393/5bc30c3e-5385-4cc6-9607-0abba8901fe4)
   
   OSM background layer
   
   
![image](https://github.com/apache/superset/assets/1701393/969bb7e1-5381-4457-8b6f-0b67b7c5624d)
   
   
![image](https://github.com/apache/superset/assets/1701393/6a0bdcf0-82dd-4a9f-afd7-028bfa4dd478)
   
   
   ### TESTING INSTRUCTIONS
   
   Select the OpenStreetMap background layer or paste a tile server URL eg. 
`tile://https://tile.osm.ch/name-it/{z}/{x}/{y}.png`, 
`tile://https://c.tile.openstreetmap.org/{z}/{x}/{y}.png`
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: 
https://github.com/apache/superset/discussions/27475
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to