goto-loop opened a new pull request, #27142: URL: https://github.com/apache/superset/pull/27142
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Fixes #25327. Currently, the selected number format gets applied to all lines of the box plot tooltip. For example, if you are displaying durations (number format "Duration in ms") and you have 3544 observations, the tooltip will say "# Observations: 3.5s". This PR removes the formatting for values which are by definition without unit, i.e. "# Observations" and "# Outliers". I am aware that it would be better to skip the formatting based on the selected format, because formats like ",d" and ".1s" can still be applied. I would argue though that no formatting still beats the current wrong formatting. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable -->   ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Open one of the Box plots that get loaded with the example database and change the number format to either duration or currency. Then hover over one of the boxes to display the tooltip. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #25327 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
