mistercrunch commented on issue #30584: URL: https://github.com/apache/superset/issues/30584#issuecomment-2448232199
Doing a quick check, seems https://github.com/apache/superset/blob/master/superset/dashboards/api.py#L1368 doesn't have the `@handle_api_exception` decorator applied, which may help in serving a json error. More generally, and tagging @dpgaspar for input, wondering if/when/where we should use the @api, @has_api_access and @handle_api_exception in api-related views. Seems we may want to make sure we have a single `@api` decorator that does it all, and make sure it's applied consitently for all API-related views (?) @dpgaspar I'm happy to take this on if we define the best approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
