mistercrunch commented on code in PR #30758:
URL: https://github.com/apache/superset/pull/30758#discussion_r1823306214
##########
superset-frontend/src/features/databases/UploadDataModel/index.tsx:
##########
@@ -173,6 +173,12 @@ const allowedExtensionsToAccept = {
columnar: '.parquet, .zip',
};
+const extensionsToLabel: Record<UploadType, string> = {
+ csv: 'CSV',
Review Comment:
did a double take on whether this needs to be wrapped with a18n, but i think
it's right to NOT make these labels translatable, maybe "Columnar" is debatable
but let's stick to non-a18n
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
