mistercrunch commented on a change in pull request #7355: [security] New,
deprecate merge_perm, FAB method is fixed
URL:
https://github.com/apache/incubator-superset/pull/7355#discussion_r279824034
##########
File path: superset/security.py
##########
@@ -262,27 +262,17 @@ def accessible_by_user(self, database, datasource_names,
schema=None):
full_names = {d.full_name for d in user_datasources}
return [d for d in datasource_names if d in full_names]
- def merge_perm(self, permission_name, view_menu_name):
Review comment:
For backwards compatibility, we should just call
`self.add_permission_view_menu` here and maybe add a deprecation warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
