mistercrunch commented on a change in pull request #6610: Add support to Apache
Drill
URL:
https://github.com/apache/incubator-superset/pull/6610#discussion_r279840819
##########
File path: superset/assets/src/components/TableSelector.jsx
##########
@@ -170,13 +170,8 @@ export default class TableSelector extends
React.PureComponent {
this.setState({ tableName: '' });
return;
}
- const namePieces = tableOpt.value.split('.');
- let tableName = namePieces[0];
- let schemaName = this.props.schema;
- if (namePieces.length > 1) {
- schemaName = namePieces[0];
- tableName = namePieces[1];
- }
+ const tableName = tableOpt.value;
+ const schemaName = this.props.schema;
Review comment:
I think if/when using `TABLE_NAMES_CACHE_CONFIG`, the logic that got removed
will be needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
