rjurney opened a new pull request #7419: Fixes missing download from Dashboard Export Action URL: https://github.com/apache/incubator-superset/pull/7419 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Strangely `window.open` followed by changing `window.location` in the export dashboard page stopped working a few months ago, possibly because of changes in browser behavior. This resulted in the Dashboard export action failing. My fix is to build a link and click it, which does work consistently. The related Python code is here: https://github.com/apache/incubator-superset/blob/master/superset/views/core.py#L675-L696 but this seems purely a Javascript issue. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN <!--- What steps should be taken to verify the changes --> I personally verified that this works but am not aware of a unit test for this function. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #7353 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @mistercrunch
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
