rjurney commented on a change in pull request #7386: Updating contributing/install docs URL: https://github.com/apache/incubator-superset/pull/7386#discussion_r279972173
########## File path: CONTRIBUTING.md ########## @@ -293,20 +293,58 @@ python setup.py build_sphinx ### Flask server -Make sure your machine meets the [OS dependencies](https://superset.incubator.apache.org/installation.html#os-dependencies) before following these steps. +#### OS Dependencies + +Make sure your machine meets the [OS dependencies](https://superset.incubator.apache.org/installation.html#os-dependencies) before following these steps. + +In addition you will need to install the mysql client to get mysql_config, which is required by mysqlclient in requirements-dev.txt. Review comment: Good idea. I'll roll removing it into this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
