dosubot[bot] commented on issue #30893: URL: https://github.com/apache/superset/issues/30893#issuecomment-2467949371
<!-- Greeting --> Hey @umeshme! 👋 I'm here to help you with any bugs, questions, or contributions you have for Superset. I'll assist you while we wait for a human maintainer to join the conversation. <!-- Answer --> The issue you're experiencing with the discard button in the embedded dashboard not functioning as expected could be related to the implementation of the discard functionality or the state management during the transition from edit mode back to view mode. The expected behavior of the discard button is to undo changes and return to the embedded dashboard view <sup>[[1]](https://github.com/apache/superset/blob/master/superset-frontend/cypress-base/cypress/e2e/dashboard/editmode.test.ts)</sup>. Here are a few things you might want to check or try: 1. **State Management**: Ensure that the state transition from edit mode to view mode is correctly handled. The `SET_EDIT_MODE` action should be dispatched with `editMode: false` to switch back to view mode <sup>[[2]](https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/actions/dashboardState.js)</sup>. 2. **Network Requests**: Since you mentioned that the network trace shows a GET call with no further activity, it might be worth investigating if there are any missing or failed network requests that should be triggered when the discard button is clicked. 3. **JavaScript Console**: Check the browser's JavaScript console for any errors or warnings that might provide more insight into what's going wrong. 4. **Code Review**: Review the implementation of the `discardChanges` function and ensure it is correctly defined and invoked. The function should handle the necessary state updates and UI transitions. If these steps don't resolve the issue, it might be helpful to look into recent changes or commits related to the embedded dashboard or discard functionality for any potential bugs or regressions. <!-- Dosu Comment Footer --> *To continue talking to [Dosu](https://dosu.dev), mention @dosu.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
