ravikantkml commented on PR #30134: URL: https://github.com/apache/superset/pull/30134#issuecomment-2468415844
> > > > > Thanks for tackling this... it's a popular request, no doubt about it. If you think it's relevant, we might also want to add an entry in the documentation somewhere. > > > > > > > > > > > > Yes agreed I definitely need to add some documentation for how to use this. I wanted to wait until I was more confident that the general approach was acceptable before working on describing how to use it. In terms of a review as part of #26319 is there anything I need to do at the moment? > > > > > > > > > Thanks for these changes. Can you please mention values for BASE_PATH and ASSET_BASE_URL. Just wanted to check these changes with superset and nginx. > > > > > > Sorry for the delay in replying to this. I've had zero time to spend on this lately. > > The latest commits rebase on the current master and I have also added some documentation to the configuring superset pages that describe the new variables with an example `nginx.conf`. Does that help? > > Thanks a lot for the response. We tried the changes as recommended and observed that most of the things are working when we specify prefix. However there are few things where prefix is not applied correctly as shown in the image below (chart menu has prefix applied correctly)  > > Also dashboard menu items export to PDF/image not working (Dashboard -> Download -> Export to PDF/Download as Image) I tried to fix above issue of missing prefixes in top-level menu. Please check this PR [2](https://github.com/martyngigg/superset/pull/2) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
