williaster commented on a change in pull request #7233: [dashboard] After
update filter, trigger new queries when charts are visible
URL:
https://github.com/apache/incubator-superset/pull/7233#discussion_r280009653
##########
File path: superset/assets/src/explore/components/ExploreViewContainer.jsx
##########
@@ -106,7 +106,6 @@ class ExploreViewContainer extends React.Component {
componentWillReceiveProps(nextProps) {
if (nextProps.controls.viz_type.value !==
this.props.controls.viz_type.value) {
this.props.actions.resetControls();
- this.props.actions.triggerQuery(true, this.props.chart.id);
Review comment:
sorry not sure I quite understand the explore view changes with the new
flow, why do we remove this line? I get that `src/chart/Chart` will now trigger
a query if its `prop.formData` prop changes, but its `props.triggerQuery` still
has to be `true` right? does that only happen with this line or something else
causes that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
