kgabryje commented on PR #30935: URL: https://github.com/apache/superset/pull/30935#issuecomment-2483397897
@jpchev This change doesn't really fix the issue, it only skips the virtualization check - which has the same effect as simply disabling virtualization (`DASHBOARD_VIRTUALIZATION = false`). In my opinion, a proper fix would be to move the PDF generation to the backend, as a Celery/Selenium job (like the screenshots - see `ENABLE_DASHBOARD_DOWNLOAD_WEBDRIVER_SCREENSHOT` flag). Until then, disabling virtualization is the only viable workaround - which should be fine unless you work on some very large dashboards -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
