john-bodley commented on a change in pull request #7422: Add "validation_only"
queries to the backend
URL:
https://github.com/apache/incubator-superset/pull/7422#discussion_r280115347
##########
File path: superset/db_engine_specs.py
##########
@@ -487,6 +488,16 @@ def get_timestamp_column(expression, column_name):
can be overridden."""
return expression or column_name
+ @classmethod
+ def make_validation_query(cls, sql):
+ """
+ If the underlying engine supports it, modify the query sql to request
+ that the database validate the query instead of running it.
+ """
+ raise Exception(
+ f'Database engine {cls.engine} does not support validation
queries')
+ return None
Review comment:
This is unreachable. Also `None` is the explicit return type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
