michael-s-molina commented on code in PR #30949:
URL: https://github.com/apache/superset/pull/30949#discussion_r1848972710
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts:
##########
@@ -314,15 +314,7 @@ export function transformSeries(
opacity: opacity * areaOpacity,
}
: undefined,
- emphasis: {
- // bold on hover as required since 5.3.0 to retain backwards feature
parity:
- //
https://apache.github.io/echarts-handbook/en/basics/release-note/5-3-0/#removing-the-default-bolding-emphasis-effect-in-the-line-chart
- // TODO: should consider only adding emphasis to currently hovered series
- lineStyle: {
- width: 'bolder',
Review Comment:
> I also removed the line boldness on hover because on dashed lines the
animation is a bit distracting.
@eschutho I believe this was added to keep the hover behavior consistent
with other chart types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
