bwa84 commented on code in PR #30987:
URL: https://github.com/apache/superset/pull/30987#discussion_r1855182554


##########
superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/types.ts:
##########
@@ -52,6 +52,10 @@ export const DEFAULT_FORM_DATA: 
Partial<EchartsSunburstFormData> = {
   labelType: EchartsSunburstLabelType.Key,
   showLabels: false,
   dateFormat: 'smart_date',
+  innerRadius: 30,
+  outerRadius: 70,
+  donut: true,
+  showNulls: true,

Review Comment:
   Default values were set with the same values that were hardcoded 
(innerRadius = 30, outerRadius = 70) or to keep current default behavior (donut 
= true, showNulls = true).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to