dosubot[bot] commented on issue #31188: URL: https://github.com/apache/superset/issues/31188#issuecomment-2505293166
<!-- Greeting --> Hi @anantmulchandani! I'm here to help you with any bugs, questions, or contributions. Let's tackle this together! [Dosu](https://dosu.dev) <!-- Answer --> The "can publish on Superset" permission is intended to allow users to publish content within Superset. This permission is typically granted to Admin, Alpha, and Gamma roles, but not to the SQL_LAB role <sup>[[1]](https://github.com/apache/superset/blob/master/RESOURCES/STANDARD_ROLES.md)</sup>. If removing this permission from roles does not change users' ability to publish dashboards, it might indicate that the permission is not being enforced as expected in the codebase. There could be several reasons for this behavior: 1. **Role Hierarchy**: Users might have other roles or permissions that still allow them to publish dashboards. Check if users have other roles that inherently grant publishing capabilities. 2. **Code Implementation**: The enforcement of this permission might not be correctly implemented in the codebase. It would be beneficial to review the code to ensure that the permission is being checked where necessary. 3. **Feature Flags**: If the `DashboardRbac` feature flag is enabled, it might affect how permissions are enforced, particularly regarding dashboard ownership and admin roles <sup>[[2]](https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/util/permissionUtils.ts)</sup><sup>[[3]](https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/util/permissionUtils.test.ts)</sup>. Since the issue persists despite removing the permission, it might be worth investigating the codebase further to ensure that the permission checks are correctly implemented and enforced. <!-- Dosu Comment Footer --> *To continue talking to [Dosu](https://dosu.dev), mention @dosu.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
