LevisNgigi commented on code in PR #31168:
URL: https://github.com/apache/superset/pull/31168#discussion_r1862577676
##########
superset-frontend/src/components/Alert/Alert.stories.tsx:
##########
@@ -44,6 +44,7 @@ export const AlertGallery = () => (
type={type}
showIcon
closable
+ closeIcon={<span aria-label="close icon">x</span>} // Custom close
icon
Review Comment:
Thanks for the suggestion! I opted to showcase the closeIcon directly in the
existing AlertGallery to keep things simple and avoid adding extra components.
Since closeIcon isn't part of the Storybook args, I think this approach still
effectively demonstrates its customization without adding another component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
