Vitor-Avila opened a new pull request, #31261:
URL: https://github.com/apache/superset/pull/31261

   ### SUMMARY
   This PR adds two new helpers to the Handlebars chart:
   * `formatNumber`: allows using `number.toLocaleString(locale)` to format 
numbers as needed.
   * `group` (via the [handlebars-group-by 
module](https://github.com/shannonmoeller/handlebars-group-by)): Allows 
grouping data.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Example using both helpers:
   
![image](https://github.com/user-attachments/assets/a9e983e2-ac0e-4b2e-9281-751d3768b40b)
   
   ### TESTING INSTRUCTIONS
   1. Create a Handlebars chart using the `cleaned_sales_data` dataset.
   2. Use `year` and `deal_size` as dimensions and create any metric with the 
`test_metric` label.
   3. Use below Handlebars template:
   ```
   {{#group data by="year"}}
   <h3>Year: {{ value }}</h3>
   <ul>
   {{#each items}}
        <li>{{ deal_size }} deals: {{ formatNumber test_metric "de-DE"}}</li>
   {{/each}}
   </ul>
   {{/group}}
   ```
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to