michael-s-molina commented on code in PR #31294:
URL: https://github.com/apache/superset/pull/31294#discussion_r1873104584
##########
superset/daos/query.py:
##########
@@ -35,25 +35,6 @@
class QueryDAO(BaseDAO[Query]):
base_filter = QueryFilter
- @staticmethod
- def update_saved_query_exec_info(query_id: int) -> None:
- """
- Propagates query execution info back to saved query if applicable
-
- :param query_id: The query id
- :return:
- """
- query = db.session.query(Query).get(query_id)
- related_saved_queries = (
- db.session.query(SavedQuery)
- .filter(SavedQuery.database == query.database)
- .filter(SavedQuery.sql == query.sql)
Review Comment:
Even though we could do an additional PUT as @justinpark suggested, I still
think showing the last time a saved query run is less important than showing
the last time it was modified. That's what the other entities show and it's
generally what users look for when they find a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
